SDK Bug & Feature Requests

Please check out the following rules and use the provided template when posting a bug report! Off-topic posts will be deleted.http://bit.ly/vrchat-bug-reports

String conversion errors from RuntimeAssembly.GetCodeBase with Japanese locale and/or paths

I've been getting reports from multiple Japanese users that they are getting the following stacktrace, breaking the build window in the Avatar SDK: ExecutionEngineException: String conversion error: Illegal byte sequence encounted in the input. System.Reflection.RuntimeAssembly.GetCodeBase (System.Reflection.Assembly a, System.Boolean escaped) (at <27124aa0e30a41659b903b822b959bc7>:0) System.Reflection.RuntimeAssembly.get_CodeBase () (at <27124aa0e30a41659b903b822b959bc7>:0) System.Reflection.AssemblyName.Create (System.Reflection.Assembly assembly, System.Boolean fillCodebase) (at <27124aa0e30a41659b903b822b959bc7>:0) System.Reflection.RuntimeAssembly.GetName (System.Boolean copiedName) (at <27124aa0e30a41659b903b822b959bc7>:0) System.Reflection.Assembly.GetName () (at <27124aa0e30a41659b903b822b959bc7>:0) VRC.Tools.get_HasTypeVRCApplication () (at <de2b87b788984fa39f4913eb18084fa8>:0) VRC.Tools.get_isClient () (at <de2b87b788984fa39f4913eb18084fa8>:0) VRC.Core.API.PopulateHTTPRequestHeaders (BestHTTP.HTTPRequest request) (at <de2b87b788984fa39f4913eb18084fa8>:0) VRC.Core.API.SendRequestInternal (System.String endpoint, BestHTTP.HTTPMethods method, VRC.Core.ApiContainer responseContainer, System.Collections.Generic.IReadOnlyDictionary`2[TKey,TValue] requestParams, System.Boolean authenticationRequired, System.Boolean disableCache, System.Single cacheLifetime, System.Int32 retryCount, VRC.Core.API+CredentialsBundle credentials, BestHTTP.Forms.HTTPFormBase formData, System.Boolean disableLog, VRC.Core.UpdateDelegator+JobPriority priority) (at <de2b87b788984fa39f4913eb18084fa8>:0) VRC.Core.API+<>c__DisplayClass49_0.<SendRequest>g__PerformRequest|0 () (at <de2b87b788984fa39f4913eb18084fa8>:0) VRC.Core.API.SendRequest (System.String endpoint, BestHTTP.HTTPMethods method, VRC.Core.ApiContainer responseContainer, System.Collections.Generic.IReadOnlyDictionary`2[TKey,TValue] requestParams, System.Boolean authenticationRequired, System.Boolean disableCache, System.Single cacheLifetime, System.Int32 retryCount, VRC.Core.API+CredentialsBundle credentials, BestHTTP.Forms.HTTPFormBase formData, System.Boolean disableLog, VRC.Core.UpdateDelegator+JobPriority priority) (at <de2b87b788984fa39f4913eb18084fa8>:0) VRC.Core.RemoteConfig.FetchConfig (System.Action onFetched, System.Action onError) (at <de2b87b788984fa39f4913eb18084fa8>:0) VRC.Core.BaseConfig.Init (System.Action onInit, System.Action onError, System.Boolean reload) (at <de2b87b788984fa39f4913eb18084fa8>:0) VRCSdkControlPanel.ShowControlPanel () (at ./Packages/com.vrchat.base/Editor/VRCSDK/Dependencies/VRChat/ControlPanel/VRCSdkControlPanel.cs:25) Some folks claim that this starts when they install Modular Avatar, and persists after removing it. It may be related to https://github.com/mono/mono/issues/20968 - calling Assembly.GetName appears to be unsafe on the version of mono in Unity 2022.3.22f1. This bug appears to be very sensitive to load order. In particular, it will occur when: Your PC nonunicode locale is Japanese, and there is Japanese text in the project path An assembly listed before Assembly-CSharp in the AppDomain.CurrentDomain.GetAssemblies() list is one which throws an exception from assembly.Name . This can be any assembly that is dynamically constructed (notably, HarmonySharedState assemblies and some "external tools" bindings, such as the Rider bindings, will trigger this) I would suggest adding exception handling to this isClient check, and skipping assemblies that throw exceptions from GetName. Or, check for the presence of VRCApplication using Assembly.GetType first, and then check for whether this is Assembly-CSharp only if you find that class.

VRCSDK should report error if the LipSync / Eyelids mode is BlendShape but not working because of bad settings

title: VRCSDK should report error if the LipSync / Eyelids mode is BlendShape but not working because of bad settings In VRCAvatarDescriptor, LipSync and Eyelids setting have BlendShape mode. In this mode, VRChat automatically controls blendShapes to make LipSync and Eyelids work. However, all the following conditions must be met for this to work: Skinned Mesh Renderer must be specified in VRCAvatarDescriptor Mesh must be specified in the specified Skinned Mesh Renderer All BlendShapes for each feature must be specified in VRCAvatarDescriptor For example, normal (closing) mouse might be enough for 'pp' viseme but not specifying BlendShape for 'pp' viseme will make LipSync entirely not working. BlendShapes specified for each feature must be unique For example, One user mistakenly specified BlendShape for 'oh' is specified for 'ss' and unexpectedly all Viseme BlendShapes become not working. Those misconfigurations likely to cause unexpected behavior and hard to find the cause (especially for third and fourth cause). Therefore, I request VRCSDK to report error as a part of avatar validation if LipSync / Eyelids settings are broken. Quick fix is to change mode to ParameterOnly (LipSync) / None (Eyelids) so auto-fixing with changing mode is also good I think.

Please provide fallback shaders with VRCSDK and API to get them from material.

Please provide fallback shaders with VRCSDK and API to get them from material. There are multiple possible use cases like: To create avatar with exactly same look with and without Fallback - Currently, since we don't have fallback shaders, we cannot create avatar consistently looks same with and without fallback. To create Editor Extensions that shows the fallback-ed version of the avatar. - There are some editors exists but their implementation might can be different. - There is no documentation that explains the exact algorithm for parsing VRCFallback tag so we don't know which shader will be applied for wired VRCFallbackTag like ToonCutoutUnlit . To retrieve list of properties used in each fallback shader. - I want to get (current) list of properties supported in each fallback shader to remove unused properties from the material. - There are list of properties copied to fallback material on creator docs, but some fallback shader may not use some properties on the list (like Toon does not use most properties but _MainTex ).

Differentiate between string and image loading requests

Currently, upon reviewing the request headers, there does not seem to be any way to differentiate between string and image loading requests for the same URL. With the limitations of VRCUrl, it would be very nice to have a way to tell them apart. Some potential solutions include specifying a value for the Accept header, extending the User-Agent header, or adding a new VRChat-specific header. I believe the last option would be the least likely to break any existing worlds, but there are various pros and cons of each. An example use-case would be a system to download a mesh (binary data, string loading) and its texture (image loading) using a single URL. The server could use the headers to determine which content it should respond with. This would also be useful for decreasing the size of VRCUrl pools as used in YTS and other worlds. We are already using useragent-dependent responses between video player and string loading useragents, but we'd like to do the same with image loading too.

Network ID Utility can fail if a GameObject is disabled

Version 3.7.1 Reproduction steps 1) Create this hierarchy: └ GO1 └ GO2 (this GameObject has the VRCObjectSync component, and is disabled) 2) "Build & Test" to generate new IDs. 3) Remove the VRCObjectSync component from GO2 4) Add the VRCObjectSync component on the GO1 GameObject 5) The hierarchy should now look like this : └ GO1 (this GameObject has the VRCObjectSync component) └ GO2 (This GameObject is still disabled) 6) "Build & Test" again => An error appears in the logs, Failed to assign network IDs, 1 errors encountered! Regenerating all network IDs fixes that issue.

tracked

VRC Constraints are Not stable

A guess someone suggestion to this problem is a "Rounding Error". This issue seems to cause the position to update despite there being no reason for it too! This causes issues where prefabs don't play nice and it acts like it doesn't apply. This is due to the position constantly changing when it shouldn't.

tracked

[Udonsharp] Watchlog causing extreme Long Reloading Domain time and Editor stuttering

PRs: https://github.com/vrchat-community/UdonSharp/pull/170 When no VRChat installation is found, reloading domain will increase dramatically and generate lot of Editor lag over time. Step to reproduce: Go to AppData/LocalLow/VRChat/VRChat/ Rename or temporary move it (like if you never launched vrchat at least once) Open a Project that has Udonsharp Udonsharp will show a message in the console "Could not locate VRChat data directory for exception watcher..." Keep the editor idling for 5-10 minutes. Enter play mode and notice a very long reloading domain time. After investigating the root cause of the issue, the issue is the "Listen for client exceptions" doing callback loops in the background, disabling it will temporary fix the issue, but a fix is in the PR.

SDK should measure accurate avatar data size.

If we are stopped before the exact avatar size is known, we will be unable to do anything. It's deadlock. Avatar data size should not be measured before build process. I'm making lot avatar which using 2k textures with clunch compression. When I updated the SDK yesterday and tried to upload after modifying Gesture, but SDK said your avatar exceeds the limit size. Fortunately, I was able to fool around with Build & Test, but I can't trust that it will always pass.

After putting your login info in the SDK, make it so pushing the "enter" key on your keyboard logs you in

Make it so after entering your info into the SDK login window, you push the Enter button on your keyboard and it acts the same as if clicking the Sign In button with your mouse. It would be a Quality of Life addition for people who make lot of projects all the time, like avatar creators who work on avatars everyday. I am sure it would be beneficial for world creators too.

interested

validator out of Range

→