SDK Bug & Feature Requests

Any project prefab containing a UdonSharpBehaviour will be recreated after being deleted. The same will happen even if the files are deleted from the file explorer. It's also happening silently without any warning in the console. Creators unaware of this could run into serious issues. This was not an issue under 3.10.4. Environment World SDK 3.10.5 Reproduction Create a project prefab with a UdonSharpBehaviour Delete that same Prefab from Unity

This issue has been occurring for a while, and while there may already be existing reports, I am reporting this again since it has remained unresolved for so long. When there are multiple avatars in the same scene and you manage them by making them active only during modifying or uploading, the following steps can cause incorrectly recognized upload targets, resulting in the information for the wrong target being updated or an error occurring by internally attempting to build a non-active avatar. (“Selected Avatar” dropdown appears to be showing the correct avatar, but the avatar information and alerts displayed are for the previous avatar.) Make one avatar active. Open the Builder tab in the Control Panel and have the SDK recognize that avatar. Close the SDK Control Panel. With the Control Panel closed, make another avatar active and set the previous avatar to inactive. Open the Control Panel again. Incorrect information is displayed. If you try to upload the avatar or update the avatar’s information, it will lead to unintended results. New users are also likely to encounter this issue, and since the problem doesn't occur if the Control Panel is kept open, other users may not know about the issue. Therefore, it can be difficult to identify the cause of these unintended results. Tested Environment: Unity: 2022.3.22f1 SDK: 3.10.4, 3.10.5-beta.1

https://feedback.vrchat.com/sdk-bug-reports/p/assets-create-u-script-fails-if-destination-file-is-outside-project-root was marked as fixed in sdk 3.10.5, but the fix was not comprehensive. Packages added from disk during development (click "Add package from disk" in unity's Package Manager tab) are not inside the project root, and now result in "UdonSharp scripts must be created inside the project's Assets or Packages folder" which is not correct. If validation is still needed, you can check if an absolute path is inside one of these "outside of root" package folders by using !Path.IsPathRooted(FileUtil.GetLogicalPath(scriptFilePath)) , and then using FileUtil.GetLogicalPath(scriptFilePath) as the projectRelativeScriptPath The Unity's CreateAsset() cannot create assets in Packages comment in the current code is also incorrect. Unity can definitely create assets within Packages, the current implementation just doesn't deduce the relative path properly. The entire method can be replaced by this implementation, which solves all of those issues: internal static string CreateUSharpScript(string folderPath, bool createProgramAsset) { string chosenFilePath = EditorUtility.SaveFilePanel("Save UdonSharp File", folderPath, string.Empty, "cs"); if (chosenFilePath.Length > 0) { string chosenDirectory = Path.GetDirectoryName(chosenFilePath)!; string sanitizedFileName = UdonSharpSettings.SanitizeName(Path.GetFileNameWithoutExtension(chosenFilePath)); string scriptFilePath = Path.Combine(chosenDirectory, $"{sanitizedFileName}.cs").Replace('\\', '/'); string assetFilePath = Path.Combine(chosenDirectory, $"{sanitizedFileName}.asset").Replace('\\', '/'); string projectRelativeScriptPath = Path.IsPathRooted(FileUtil.GetLogicalPath(scriptFilePath)) ? FileUtil.GetProjectRelativePath(scriptFilePath) : FileUtil.GetLogicalPath(scriptFilePath); string projectRelativeAssetPath = Path.IsPathRooted(FileUtil.GetLogicalPath(assetFilePath)) ? FileUtil.GetProjectRelativePath(assetFilePath) : FileUtil.GetLogicalPath(assetFilePath); if (projectRelativeScriptPath.Length == 0) { EditorUtility.DisplayDialog("Invalid path", "UdonSharp scripts must be created inside the project's Assets or Packages folders.", "Ok"); return null; } if (createProgramAsset) { if (AssetDatabase.LoadAssetAtPath<UdonSharpProgramAsset>(projectRelativeAssetPath) != null) { if (!EditorUtility.DisplayDialog("File already exists", $"Corresponding asset file '{projectRelativeAssetPath}' already found for new UdonSharp script. Overwrite?", "Ok", "Cancel")) { return null; } } } // Commit to creation from this point string fileContents = UdonSharpSettings.GetProgramTemplateString(sanitizedFileName); File.WriteAllText(scriptFilePath, fileContents, System.Text.Encoding.UTF8); AssetDatabase.ImportAsset(projectRelativeScriptPath, ImportAssetOptions.ForceSynchronousImport); if (createProgramAsset) { MonoScript newScript = AssetDatabase.LoadAssetAtPath<MonoScript>(projectRelativeScriptPath); UdonSharpProgramAsset newProgramAsset = CreateInstance<UdonSharpProgramAsset>(); newProgramAsset.sourceCsScript = newScript; AssetDatabase.CreateAsset(newProgramAsset, projectRelativeAssetPath); } AssetDatabase.Refresh(); return projectRelativeScriptPath; } return null; }

While normal map textures still show the preview as the normal lavender-ish color for normal maps, but the it seems like the generated mipmap levels are light-red, as visible in the lower project window texture preview icon. (screenshot attached) This causes everything in my world that uses a normal map to be excessively shiny/reflective, and lights bleed through walls and floors. As a workaround, I can individually switch all my normal map textures to Box instead of "Kaiser", but then the world upload linter then warns about these and pressures me to let it switch them back to (the broken) "Kaiser". I have had to disable DPID for my world for the time being.

With SDK version 3.7.5 several settings were migrated from the static class VRCSettings , existing within the VRCSDKBase-Editor.dll library provided alongside the SDK to VRCPackageSettings , the change also included a refactor of the class, introducing a static property Instance , used to get or create an instance of the class, an instance is attempted to be created by the PerceptualPostProcessor as DPID settings were part of the migration, however this fails because of a null exception: VRCPackageSettings.Instance.dpidMipmaps within PerceptualPostProcessor executes VRCPackageSettings.Instance_get VRCPackageSettings._instance is null so Create() is called, which calls Load() Load() and calls within it, including EnsurePathExists() expect GetPath() to not be null, causing a null exception when it is because GetPath() calls GetPathFromType(GetType()) which calls UnityEditor.PackageManager.PackageInfo.FindForAssembly(t.Assembly) and returns null when executed by a worker process, GetPathFromType then returns null (a comment assumes this would only occur when the SDK is not located within the Packages folder) but this execution path was seemingly never tested and so methods that expect valid strings such as Directory.CreateDirectory within EnsurePathExists() throw null exceptions. Simply resolving the null exceptions is not enough as the current implementation would cause Load() to not load any data when it's meant to, leading to VRCPackageSettings.Instance to contain default values when executed by worker processes ( AssetDatabase.IsAssetImportWorkerProcess() ), you cannot simply abort execution because that invalidates the use of Parallel Import and would cause textures marked as "dirty" to not actually be updated to have mipmaps re-generated, a proper solution leading to the same settings file must be implemented, the whole dependency on the assembly's package info seems extreme. This can be easily reproduced on any 3.7.5+ project with Parallel Import enabled (Project Settings -> Editor, mine is configured with 8 desired workers and 2 on standby) by enabling/disabling "Override Kaiser mipmapping" in the SDK settings.

Similar to https://feedback.vrchat.com/sdk-bug-reports/p/vrcsdk-packagejson-is-missing-dependency-on-unity-ui but for different packages com.vrchat.base requires the following packages, but not included in package.json com.unity.modules.physics2d (DOTween requires that) com.unity.modules.video ( WorldValidation.cs requires that) com.unity.test-framework ( Packages/com.vrchat.base/Editor/VRCSDK/Dependencies/VRChat/Tests/ and com.vrchat.base/Editor/VRCSDK/VTP/VTPTests.cs requires that) In addition, com.unity.xr.oculus which is dependency of com.vrchat.base , requires the following package. This missing dependency should be fixed by unity side, but having dependency by VRChat SDK prevents future problems. com.unity.modules.androidjni For com.unity.test-framework , removing related code from VRCSDK instead of adding com.unity.test-framework to package.json can also be a solution I think. For other packages, please add these packages with corresponding version to package.json of com.vrchat.base . I tested with 3.10.5 and 3.10.5-beta.1 with completely blank project manually created originally for finding missing dependency on my tool.

Unity: 2022.3.22f1 VRChat SDK - Worlds: 3.10.4 Title: ClientSim corrupts PlayerObject strings containing nested JSON Environment: Unity 2022.3.22f1 Worlds SDK 3.10.4 Reproduction: Add an Udon-synced string to a PlayerObject. Store JSON containing another serialized JSON string: {"outerKey":"[\"innerValue\"]"} Call RequestSerialization() and allow ClientSim to save the PlayerObject. Exit and enter Play Mode again. ClientSim fails while restoring the saved PlayerObject. ClientSim saves: "{\"outerKey\":\"[\\"innerValue\\"]\"}" It should save: "{\"outerKey\":\"[\\\"innerValue\\\"]\"}" The backslash preceding each nested quote is not escaped for the additional ClientSim JSON storage layer. The malformed value is loaded as a DataToken.Error, but ClientSim then accesses it as a DataDictionary in ClientSimNetworkIdHolder.Decode() line 180 As a result, the PlayerObject is not restored and all persistence stored in it appears lost. ClientSim may subsequently overwrite the file with empty/default data. The same nested JSON persistence seems to works correctly in the real VRChat client, so this appears to be specific to ClientSim’s local PlayerObject save/load implementation. Trace stack: InvalidOperationException: Attempted to access Error token as DataDictionary VRC.SDK3.Data .DataToken.get_DataDictionary () (at <8dae6d6858f2465fad961e5d8ef394cc>:0) VRC.SDK3.ClientSim.ClientSimNetworkIdHolder.Decode ( VRC.SDK3.Data .DataList data) (at ./Packages/com.vrchat.worlds/Integrations/ClientSim/Runtime/Networking/ClientSimNetworkIdHolder.cs:180) VRC.SDK3.ClientSim.ClientSimNetworkingView.Decode ( VRC.SDK3.Data .DataList data) (at ./Packages/com.vrchat.worlds/Integrations/ClientSim/Runtime/Networking/ClientSimNetworkingView.cs:95) VRC.SDK3.ClientSim.Persistence.ClientSimPlayerObjectStorage.Decode () (at ./Packages/com.vrchat.worlds/Integrations/ClientSim/Runtime/Player/PlayerPersistence/ClientSimPlayerObjectStorage.cs:165) VRC.SDK3.ClientSim.Persistence.ClientSimPlayerObjectStorage.OnPlayerJoined (VRC.SDK3.ClientSim.ClientSimOnPlayerJoinedEvent payload) (at ./Packages/com.vrchat.worlds/Integrations/ClientSim/Runtime/Player/PlayerPersistence/ClientSimPlayerObjectStorage.cs:102) VRC.SDK3.ClientSim.ClientSimEventDispatcher.SendEvent[T] (T clientSimEvent) (at ./Packages/com.vrchat.worlds/Integrations/ClientSim/Runtime/Events/ClientSimEventDispatcher.cs:62) VRC.SDK3.ClientSim.ClientSimPlayerManager.DispatchPlayerJoinedEvent (VRC.SDKBase.VRCPlayerApi player) (at ./Packages/com.vrchat.worlds/Integrations/ClientSim/Runtime/System/ClientSimPlayerManager.cs:137) VRC.SDK3.ClientSim.ClientSimPlayerManager.OnClientSimReady () (at ./Packages/com.vrchat.worlds/Integrations/ClientSim/Runtime/System/ClientSimPlayerManager.cs:129) VRC.SDK3.ClientSim.ClientSimMain+<InitializeClientSim>d__45.MoveNext () (at ./Packages/com.vrchat.worlds/Integrations/ClientSim/Runtime/System/ClientSimMain.cs:399) UnityEngine.SetupCoroutine.InvokeMoveNext (System.Collections.IEnumerator enumerator, System.IntPtr returnValueAddress) (at <cb81df0c49c643b1a04d9fc6ccca2433>:0)

This affects all versions from when Multi-Upload was added through the current 3.10.4 . If all three platforms are selected for multi-upload, the SDK will successfully upload each platform, but then it will continue in an infinite loop of uploading each platform over and over again forever. Uploading just Android and iOS seems to work fine.

When creating a tween with VRCTweenHandle.SetSpeedBased() , there is no way to call VRCTweenHandle.ChangeEndValue() and have the tween refresh its duration. This is due to the fact that internally dotween doesn't call Tween.DOStartupDurationBased() within Tween.DoChangeEndValue() unless a duration is specified - because VRCTween doesn't provide a duration, it calls it with -1, which means that it never calls the duration update. Additionally, because VRCTweenHandle.SetDuration() sets the duration directly via reflection, there is no chance for it to recalculate the tween, and VRCTweenHandle.SetSpeedBased() - and thus TweenSettingsExtensions.SetSpeedBased() - this only sets it so other hooks update their values, which means that the value is never propagated. This renders speed-based tween values useless for continuous motion. Sample code to prove it: class Blah : UdonSharpBehaviour { public float value; private VRCTweenHandle _handle; public void _FadeUp() { _TweenTo(1, 0.1f); } public void _FadeDown() { _TweenTo(0, 0.1f); } public void _TweenTo(float target, float speed) { if (_handle.IsActive) { _handle.ChangeEndValue(target, true) .SetDuration(speed) .SetSpeedBased(); } else { _handle = VRCTween.TweenFloat(value, target, speed, this, nameof(value), "_DummyCall", VRCTweenEase.Linear) .SetSpeedBased(); } } } If you trigger _FadeUp and _FadeDown, you will see that if the tween is not freshly created, it will result in it ignoring duration. No matter how you change the ChangeEndValue branch (aside from recalculating the values yourself) you will see it will never result in a consistent transition speed. SDK version is worlds 3.10.4, unity version 2022.3.22f1

VRChat Version: VRChat SDK - World 3.5.0 VRChat SDK - Base 3.5.0 Description of the bug: When adding components created with UdonSharp to a GameObject and then either creating a prefab from this GameObject or saving changes to an existing prefab, an error occurs. This happens in the mentioned versions of the VRChat SDK. Despite the error, the functionality appears to be unaffected. ErrorMessages: ArgumentNullException: Value cannot be null. Parameter name: unityObject All Error Message https://gist.github.com/nmxi/c9404d5094b9774656a5a6e2b219da16 Steps to reproduce (how did you encounter the bug?): Method 1: Create an empty UdonSharp script. Create an EmptyGameObject in the scene. Add the UdonSharp script from step 1 to the GameObject from step 2. Convert the GameObject into a prefab. Error occurs. Method 2: Open the prefab created in Method 1 using the Prefab Editor. Modify a value (example: changing SynchronizationMethod). Save the prefab. Error occurs.