RuneFox237
With the recent-ish change that makes particle lights correctly count towards your total light count, I noticed a possible discrepancy with the total count.
Steps to recreate:
  1. Add a Particle System to the avatar
  2. In the Particle System, scroll down to Lights
  3. Create a Point Light in the scene but outside the avatar
  4. Create a prefab of the Point Light
  5. Insert the Point Light prefab into the Light slot inside the Particle System
  6. Limit Maximum Lights to 1.
  7. Upload to VRChat
  8. Observe avatar details of avatar. Lights will be listed as 2/1
Example of an avatar that only has 1 Max Particle Light on the entire avatar but is listed as 2/1 lights in the avatar details
https://vrchat.com/home/avatar/avtr_7c80a2a5-3473-421f-86ce-fdda8fa8eb3f
Expected behavior:
Lights should be listed as 1/1.
Though I expect the 2/1 is likely due to the server-side(?) performance check adding both the light in the light prefab itself (Even though that prefab itself is not included in the hierarchy on the main avatar and is only used on the particle system) and the maximum lights in the particle system.
I understand that this is a relatively niche usecase as most people would likely just use a a regular light, but having this singular light be part of a particle effect allows for some neat control of the light through manipulation of the particle. i.e. I use it as a way to add noise to the the size and intensity of the light which would be more complicated to implement using a normal light.
Also, is it possible to update the performance stat calculation of SDK Test avatars to match the new behavior? It's still using the old behavior that only counts the prefab and not the particle light count itself. I need to upload the avatar to see the correct stats.