Groups Audit Log inconsistent data
complete
miner28_3
The groups Audit log is extremely inconsistent, returns invalid data or doesn't return the necessary data in some cases.
Log types and their issues:
.1. group.member.role.unassign
- Returns Null for actor_displayname and target_id - Should likely return user_id of the user who lost the role as target_id
.2. group.member.role.assign (Non-CE)
- Returns Null for actor_displayname and target_id- should at minimum return the user who got their role added in target_id
.3. group.invite.create
- 3.1 (Inviting)
- Returns GroupMemberId in target_id- this ID is invalid and does not belong to any user because at the time of inviting them they are not yet member of the group. Which makes it impossible to fetch them - Should likely be usr_id or data should contain usr_id of the invited user
- 3.2 (Uninviting)
- As above returns member_id instead of usr_id
- There is no way to differentiate between invite and uninvite - Should likely have group.invite.delete log_type
.4. group.member.update
- Returns Null for actor_displayname and target_id- should at minimum return the user who got their membership updated in target_id
Log In
StormRel
API changes based on this feedback have just gone out:
targetType group.member renamed to group.member.user
all audit logs for targetType group.member.user have had their targetId adjusted to the target userId rather than internal membershipId
ban/unban audit logs targetType changed to group.member.user from user to match above change
eventType group.member.update renamed to group.member.user.update
targetId should no longer ever be null
actorDisplayName should no longer ever be null
group uninvite eventType correctly renamed to group.invite.cancel
fixed incorrect targetId in group.gallery.create eventType
added new eventType group.request.create
admin actions will now consistently have actorId as vrc_admin and actorDisplayName as VRChat Admin
system actions will now consistently have actorId as vrc_system and actorDisplayName as VRChat System
If you find anymore inconsistencies please report them! We try our best to ensure these kinds of systems are solid, but in any sufficiently complex application little things are occasionally missed.
StormRel
API changes based on this feedback have just gone out:
targetType group.member renamed to group.member.user
all audit logs for targetType group.member.user have had their targetId adjusted to the target userId rather than internal membershipId
ban/unban audit logs targetType changed to group.member.user from user to match above change
eventType group.member.update renamed to group.member.user.update
targetId should no longer ever be null
actorDisplayName should no longer ever be null
group uninvite eventType correctly renamed to group.invite.cancel
fixed incorrect targetId in group.gallery.create eventType
added new eventType group.request.create
admin actions will now consistently have actorId as vrc_admin and actorDisplayName as VRChat Admin
system actions will now consistently have actorId as vrc_system and actorDisplayName as VRChat System
If you find anymore inconsistencies please report them! We try our best to ensure these kinds of systems are solid, but in any sufficiently complex application little things are occasionally missed.
miner28_3
StormRel Thanks a lot! This means a lot to me and anyone dealing with the group API! Love all the changes, and thank you greatly for such a quick fix.
This post was marked as
complete
This post was marked as
available in future release
StormRel
tracked